search

jamesplease / materialish

React components that loosely follow Material Design
https://materialish.js.org
MIT License
17 stars 5 forks source link

add Materialish typings (just for Button) #284

Closed dannycochran closed 6 years ago

dannycochran commented 6 years ago

this PR adds a typings file that can be used for adding typings definitions for all exported materialish functions / classes.

Though it is possible to break up typings files by component (e.g. into button/button.d.ts), and then merge them using a tool like dts-generator -- we've received caution that that tool can be buggy.

Official support for bundling typings files should arrive soon, at which breaking apart the files will be possible:

https://github.com/Microsoft/TypeScript/issues/4433

jamesplease commented 6 years ago

I chatted with @dannycochran offline, and he suggested we add these to DefinitelyTyped instead. I think that's worth trying.

For that reason, I'm going to close this out. But I am super excited to add typings to this library, and I appreciate you taking the time to set this up @dannycochran !

I opened an issue to track adding this to DT over here.