search

jamesplease / materialish

React components that loosely follow Material Design
https://materialish.js.org
MIT License
17 stars 5 forks source link

Ripple spread prop? #99

Closed jamesplease closed 6 years ago

jamesplease commented 6 years ago

@JPorry , the Ripple accepts a spread prop, but I don't think that it is being used. Perhaps this is code from a previous version that you meant to remove, or code that was never finished? What do you think?

It's not used because this.el is never set on the component (it has no refs). I figure we either need to remove the usage of the prop, or add the ref. What was your intention here?

jamesplease commented 6 years ago

We chatted offline; we can get rid of dis