search

jamesread / prometheus-gmail-exporter

Checks gmail labels for unread messages and exposes the counts via prometheus.
Apache License 2.0
47 stars 9 forks source link

Add requirements.txt for pip install (and document it on the README) #8

Closed vorburger closed 1 year ago

vorburger commented 1 year ago

@jamesread do you think this is a good idea and would be useful?

Full disclosure: I'm a total Python noob! But I tried this project out (in a Debian environment; I personally regularly use both Fedora and Debian) and wanted to have a fully reproducible dev set-up with pip instead of DNF / DEB system packages for everything which your code needs - and, far as as I understand, this is the typical way to do it in Python-land, apparently? (I didn't actually hand write this requirements.txt, but created it using pip install pipreqs && pipreqs.

jamesread commented 1 year ago

Hey @vorburger , did you want to move to a more interactive chat? Discord, Telegram, etc?

I had actually started working on two branches in the background (which I've just pushed), 1) porting this app to golang (which I generally prefer over python now-a-days), and 2) porting this python version to do "online auth", rather than the "offline auth" the code currently relies on.

vorburger commented 1 year ago

Hey @vorburger , I've added some comments/questions to the review. Could you reply to those comments? Thanks!

@jamesread done!

Hey @vorburger , did you want to move to a more interactive chat? Discord, Telegram, etc?

That's awfully kind of you to offer! ATM I need to work on this between things, and async via GitHub Issues/PR seems simplest for that, for me; hope that's OK for you. Maybe later? 🥲

I had actually started working on two branches in the background (which I've just pushed), 1) porting this app to golang (which I generally prefer over python now-a-days), and 2) porting this python version to do "online auth", rather than the "offline auth" the code currently relies on.

Oh, wow; neat! Re. do "online auth", rather than the "offline auth", let's take that up in #9? Re. Go, tell you what, let me first actually get this fully up and running as-is (FYI I actually 🤣 haven't, yet...), and then if I manage use it for a while myself, and then if I want to make any further contributions I would be interested in doing those to the Go variant, because I'm actually a little more familiar with that than with Python. SGTY?

jamesread commented 1 year ago

Thanks for making the changes based on my feedback, accepted and merged. Many thanks @vorburger !