search

jamesremuscat / avx

A system for controlling A/V devices such as video switchers via a networkable control device.
4 stars 1 forks source link

Support custom logging configuration #60

Closed jamesremuscat closed 8 years ago

jamesremuscat commented 8 years ago

At the moment, our Python logging configuration is hardcoded in Controller.py.

It should be possible to specify logging options in a controller's config file, say under the key logging. We should pass the dict straight through to logging.config.dictConfig.

The -d / --debug flag should continue to work, and we should have sensible defaults in case no other options are provided (and for before the configuration is loaded).

(Motivation: being able to log to syslog, and hence be able to monitor via papertrail etc.)

rjmunro commented 8 years ago

Logging to Papertrail sounds like a cool idea.

jamesremuscat commented 8 years ago

In order to simplify implementation, by "continue to work" I mean that the presence of the debug flag should mean that the default logger level should be set to "DEBUG", overriding what is specified in the configuration file if necessary.

There's no way of knowing what arbitrary logging configuration the user might have specified, and if they've gone to the trouble of configuring their own logging then it's not too strenuous for them to adjust its levels if needed.