search

jamesrhester / CrystalInfoFramework.jl

Julia tools for reading Crystallographic Information Framework (CIF) files and dictionaries
GNU General Public License v3.0
12 stars 3 forks source link

Distribute libcif with Julia's artifacts system #7

Closed Guillawme closed 2 years ago

Guillawme commented 3 years ago

Hello,

For systems that don't provide cifapi/libcif in their default package manager, it could be helpful to distribute it through Julia's artifacts system. Its license allows redistribution.

jamesrhester commented 3 years ago

libcif requires both unicode libraries and sqlite libraries, so it is not as lightweight as it looks. Note that CrystalInfoFramework should be fully functional without libcif and the speed difference is less than it used to be, so an alternative plan might be to remove libcif completely.

Guillawme commented 3 years ago

Ah, ok. I thought the difference was still relevant because using the native parser emits a warning. And I had not thought about the whole dependency chain, which indeed complicates things quite a bit.

jamesrhester commented 3 years ago

Should the native parser become the default, then there is no reason to emit a warning if it uses the Julia parser instead of the C parser.

jamesrhester commented 2 years ago

Commit e59b52034171b8c7e0b8b43144c690dce03e7647 adds libcif support via cif_api_jll. It doesn't work for Windows, seems to be a problem with detecting end of file. Other platforms now do not need separate installation of cif_api.