search

jamesrwhite / minicron

🕰️ Monitor your cron jobs
GNU General Public License v3.0
2.34k stars 154 forks source link

Alerts Sending Multiple Times and for False Positives #127

Closed shortjared closed 9 years ago

shortjared commented 9 years ago

The alerting system seems to have some serious issues.

This is all found while running against remote machines with the Minicron agent talking to the hub. I even tried from a completely fresh install of Minicron and fresh database.

If you create a job that is supposed to run at 1 in the morning, but you created the job at 5pm in the day... the alerting system thinks the job has been missed and fires off alerts.

If a job has been missed, it repeatedly sends alerts every minute that the job has been missed. It doesn't just send it once like I would expect.

jamesrwhite commented 9 years ago

I'll have a look into this, thanks for reporting.

jamesrwhite commented 9 years ago

If a job has been missed, it repeatedly sends alerts every minute that the job has been missed. It doesn't just send it once like I would expect.

I may need a bit more help with this as that definitely isn't the intended behaviour, it should be one alert per missed schedule. The only reason you should get one every minute is if your job schedule was * * * * * and for whatever reason they were all missing execution. Could you provide the schedules your seeing this issue with and the data in your alerts table?

jamesrwhite commented 9 years ago

The above commit should resolve:

If you create a job that is supposed to run at 1 in the morning, but you created the job at 5pm in the day... the alerting system thinks the job has been missed and fires off alerts.