search

jamessanford / remote-tsdb-clickhouse

A remote writer/reader for Prometheus that stores TSDB data in ClickHouse
Apache License 2.0
32 stars 13 forks source link

Revert "Update the recommended ORDER BY for metrics.samples table" #10

Closed jamessanford closed 6 months ago

jamessanford commented 6 months ago

This reverts commit 33e6057500b56d138af8a483aee1b3051ff3b947.

The suggestion in this commit causes a regression in the compression ratio of the "value" field as the rows were no longer sorted by updated_at.

jamessanford commented 6 months ago

My generated test data was too random for me to notice the regression in compression ratio with the different ORDER BY suggestion -- I only noticed it once I switched more of my real data over to it.

Back to the original ORDER BY for now!