search

jamessdixon / Kaggle.HomeDepot

Repo for Kaggle Competiton
MIT License
11 stars 10 forks source link

Consolidate 2 functions in benchmarkScore.fsx #2

Closed jamessdixon closed 8 years ago

jamessdixon commented 8 years ago

trainInput and testInput are almost identical. They can be consolidated into a single function

taylorwood commented 8 years ago

I took a quick stab at this, but I'm not sure how to define a function that works with the CSV type provider's generated row type.

jamessdixon commented 8 years ago

Did you submit a pull request?

taylorwood commented 8 years ago

Nope, couldn't figure out how to define a function that takes the generated CSV type or if that's even possible. I guess we could map those values to a tuple/record, maybe not worth it.

jamessdixon commented 8 years ago

Perhaps I wasn't thinking clearly when I thought of this. I'll take a look and consolidate. Right now, I am neck deep in Python port...

tjaskula commented 8 years ago

Don't forget to push the card in trello to done :) With the comment that it's not done :)