search

jamesshore / quixote

CSS unit and integration testing
Other
848 stars 45 forks source link

Enable passing in a raw css string #40

Closed SamGraber closed 6 years ago

SamGraber commented 7 years ago

This gives the user flexibility in case they want to load up the css through a module loader and then pass it through as a string.

I'm not very familiar with the frame load callback works. If I put the loadRawCSS call after loadStylesheets it didn't seem to set the styles until after the test assertions run. However, if you don't have a stylesheet, the load callback never gets called. To get around this, I'm currently checking to see if there are no stylesheets and calling the load callback immediately after the raw css is loaded up. I would welcome any feedback on the 'right' way to do this.

https://github.com/jamesshore/quixote/issues/39

jamesshore commented 7 years ago

Thanks for this. I plan to integrate it after the 0.13 release--sorry for the delay!

jamesshore commented 6 years ago

Integrated, thank you. Will be included in v0.13.