v1.6.0 - Breaking Change: RollupEvaluator updates

jamessimone commented 10 months ago

Breaking Changes

Fixes #494 by properly parsing calc item where clauses. This is the first breaking change in the last 90 releases of Apex Rollup, due to the chance that subscribers were using the SQL-based negation syntax: Field NOT LIKE 'someValue%', for example, as opposed to the SOQL-compliant syntax: NOT(Field LIKE 'someValue%').
- I've striven to make as few breaking changes to Apex Rollup as is possible over the last three years. This is a change that I'm excited to make, however! I was jumping through quite a few hoops with the prior RollupEvaluator implementation, which meant that I was never surprised when people raised issues about where clause parsing.
- These changes come with both performance benefits for people making use of where clauses (less CPU time spent parsing the clauses, notably), as well as a tighter adherence to the SOQL standard for where clauses. I plan to further open source the parsing section of this codebase as a reusable SOQL-parsing solution

Standard Changes

Updating Rollup app name to Apex Rollup as per #516
Further README cleanup based on #515
Fixes #517 by preventing a NPE on calc items that don't have matching grandparents

jamessimone commented 10 months ago

@jongpie adding you as a reviewer - no rush in taking a look!

jamessimone commented 10 months ago

@jongpie thank you! It really means a lot to me to have had you review this. I know the PR really ballooned in size with the addition of the Winter 24 updates, sorry for the additional noise there.

jongpie commented 10 months ago

@jamessimone no problem! Always happy to help - and I'm really jazzed about this changes 🥳

codecov[bot] commented 10 months ago

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (8d45ddf) 97.03% compared to head (e856c0c) 96.43%.

:exclamation: Current head e856c0c differs from pull request most recent head 1980b76. Consider uploading reports for the commit 1980b76 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #520 +/- ## ========================================== - Coverage 97.03% 96.43% -0.61% ========================================== Files 33 32 -1 Lines 6602 6584 -18 Branches 54 57 +3 ========================================== - Hits 6406 6349 -57 - Misses 195 231 +36 - Partials 1 4 +3 ``` | [Flag](https://app.codecov.io/gh/jamessimone/apex-rollup/pull/520/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Simone) | Coverage Δ | | |---|---|---| | [Apex](https://app.codecov.io/gh/jamessimone/apex-rollup/pull/520/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Simone) | `96.66% <89.66%> (-0.39%)` | :arrow_down: | | [LWC](https://app.codecov.io/gh/jamessimone/apex-rollup/pull/520/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Simone) | `91.77% <55.55%> (-4.88%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Simone#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/jamessimone/apex-rollup/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Simone) | Coverage Δ | | |---|---|---| | [rollup/core/classes/RollupCalcItemSorter.cls](https://app.codecov.io/gh/jamessimone/apex-rollup/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Simone#diff-cm9sbHVwL2NvcmUvY2xhc3Nlcy9Sb2xsdXBDYWxjSXRlbVNvcnRlci5jbHM=) | `98.63% <100.00%> (-0.04%)` | :arrow_down: | | [rollup/core/classes/RollupCalculator.cls](https://app.codecov.io/gh/jamessimone/apex-rollup/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Simone#diff-cm9sbHVwL2NvcmUvY2xhc3Nlcy9Sb2xsdXBDYWxjdWxhdG9yLmNscw==) | `98.89% <100.00%> (ø)` | | | [rollup/core/classes/RollupFieldInitializer.cls](https://app.codecov.io/gh/jamessimone/apex-rollup/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Simone#diff-cm9sbHVwL2NvcmUvY2xhc3Nlcy9Sb2xsdXBGaWVsZEluaXRpYWxpemVyLmNscw==) | `99.00% <100.00%> (-0.02%)` | :arrow_down: | | [rollup/core/classes/RollupLogger.cls](https://app.codecov.io/gh/jamessimone/apex-rollup/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Simone#diff-cm9sbHVwL2NvcmUvY2xhc3Nlcy9Sb2xsdXBMb2dnZXIuY2xz) | `89.81% <ø> (ø)` | | | [rollup/core/classes/RollupQueryBuilder.cls](https://app.codecov.io/gh/jamessimone/apex-rollup/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Simone#diff-cm9sbHVwL2NvcmUvY2xhc3Nlcy9Sb2xsdXBRdWVyeUJ1aWxkZXIuY2xz) | `96.46% <100.00%> (+0.06%)` | :arrow_up: | | [rollup/core/classes/RollupSObjectUpdater.cls](https://app.codecov.io/gh/jamessimone/apex-rollup/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Simone#diff-cm9sbHVwL2NvcmUvY2xhc3Nlcy9Sb2xsdXBTT2JqZWN0VXBkYXRlci5jbHM=) | `97.90% <100.00%> (-0.02%)` | :arrow_down: | | [...lup/core/classes/RollupRelationshipFieldFinder.cls](https://app.codecov.io/gh/jamessimone/apex-rollup/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Simone#diff-cm9sbHVwL2NvcmUvY2xhc3Nlcy9Sb2xsdXBSZWxhdGlvbnNoaXBGaWVsZEZpbmRlci5jbHM=) | `97.68% <92.30%> (-0.20%)` | :arrow_down: | | [rollup/core/classes/RollupAsyncProcessor.cls](https://app.codecov.io/gh/jamessimone/apex-rollup/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Simone#diff-cm9sbHVwL2NvcmUvY2xhc3Nlcy9Sb2xsdXBBc3luY1Byb2Nlc3Nvci5jbHM=) | `93.80% <96.96%> (-0.16%)` | :arrow_down: | | [...llupForceRecalculation/rollupForceRecalculation.js](https://app.codecov.io/gh/jamessimone/apex-rollup/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Simone#diff-cm9sbHVwL2FwcC9sd2Mvcm9sbHVwRm9yY2VSZWNhbGN1bGF0aW9uL3JvbGx1cEZvcmNlUmVjYWxjdWxhdGlvbi5qcw==) | `87.42% <55.55%> (-9.22%)` | :arrow_down: | | [rollup/core/classes/RollupEvaluator.cls](https://app.codecov.io/gh/jamessimone/apex-rollup/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=James+Simone#diff-cm9sbHVwL2NvcmUvY2xhc3Nlcy9Sb2xsdXBFdmFsdWF0b3IuY2xz) | `91.63% <85.49%> (-4.01%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jamessimone / apex-rollup