search

jamessimone / apex-rollup

Fast, configurable, elastically scaling custom rollup solution. Apex Invocable action, one-liner Apex trigger/CMDT-driven logic, and scheduled Apex-ready.
MIT License
220 stars 30 forks source link

Update Rollup.cls #609

Closed bfalter closed 3 months ago

bfalter commented 3 months ago

Fix for https://github.com/jamessimone/apex-rollup/issues/607

jamessimone commented 3 months ago

This test (RollupFlowTests.shouldReportErrorWhenConcatDelimiterSetAndNotConcat) has been passing as-is since #597. This PR would be a breaking change as explained in your first commit.

What version of Apex Rollup are you running? I think perhaps it might help to clarify how you're experiencing the test failure, rather than this PR as it currently stands.

bfalter commented 3 months ago

@jamessimone 1.6.29 with extra coverage plugin 0.0.22

bfalter commented 3 months ago

@jamessimone if that introduces a breaking change, perhaps it would make sense to add the additional space to the expected value rather than the .trim() method

jamessimone commented 3 months ago

@bfalter I can see that the Extra Code Coverage plugin needs to be regenerated, it was last regenerated off of 1.6.26, which was the version prior to #597 - that's why you're running into this. I can incorporate your suggestion in a more wholistic fashion with v1.6.30 which I will release today

bfalter commented 3 months ago

@jamessimone sounds good to me!