Closed jamestagal closed 2 years ago
Hi @jamestagal
Ahh, your changes sort of created or highlighted a "bug", depending on how you want to look at it.
I noticed that rather than changing the title from "Project" to "Post" in the "content\proj\projs.json" and "navbar.svelte", you renamed the file "content\proj\projs.json" to "content\proj\posts.json"... as a result, the logic that was using content.path
to set the active
CSS attribute stopped working.
That said, I believe that the best solution would be to switch from content.path
to content.type
. For example, lines 104 to 113 in the navbar.svelte would be:
<a class="block md:inline-flex px-2 py-1 md:py-0" href="."
><span class="navmenu{content.type == 'index' ? ' active' : ''}"
>Home</span
></a
>
<a class="block md:inline-flex px-2 py-1 md:py-0" href="posts/"
><span class="navmenu{content.type == 'projs' ? ' active' : ''}"
>Posts</span
></a
>
I will apply that fix to the template.
I've noticed that some of your changes were much more "brute force" than required and is causing extra work. You might want to refactor your project so that it is easier for you to maintain and customize going forward. Let me know if it would make sense to discuss over Zoom sometime.
Cheers, Roberto
Hi @roobyz
Yes I see the problem. It might be easier to return / refactor it back to something more maintainable for me. I would really appreciate discussing it when you are free. I live in the capital city of Australia, Canberra which is in the Australian Eastern Daylight Time zone (GMT+11). I work from home so I am very flexible in terms of a time. Please let me know a day and time that suits you.
UPDATE: changing from content.path
to content.type
and changing the '/'
to 'index'
for the Home page route worked as you mentioned above. :) Thank you
Best regards, Ben
Hi @jamestagal,,
I'm glad it worked.
I am familiar with Canberra. I lived in Brisbane for 18 months while working for Suncorp Group. Did a bit of travel to Sydney and Melbourne. ;-) I'm on San Francisco time. I think it is about 19 hours difference. My schedule during the work week is rather crazy. A good time for me might be:
Best, Roberto
Hi @roobyz Great! I think 3pm San Francisco time would work for me. Please schedule me in when you can.. :)
Best regards, Ben
hi @jamestagal,
A lot of what happens in the code is a result of working on arrays of objects. Some quick tutorials that might be helpful to level up:
Cheers, Roberto
Hi @roobyz Thanks for the links to these tutorials.. They are well explained with clear examples. I also have been trying out https://grasshopper.app/ a Google created app for learning coding and it is quite a good beginner course because it really scaffolds the fundamental concepts with practical code activities and challenges getting you to apply your knowledge and write mini code snippets to solve real problems. Cheers, Ben
Hi @roobyz Also let me know when you would be able to meet! My questions are building. :) But also I have been implementing a couple of design features into my app.
Also I found a little bug with the loading of Categories and Tags in the process; they are not updating when moving from Tag to Tag or Category to Category. I will post this one as an issue so you can look at it.
Cheers, Ben
hi @jamestagal Let me know if you are available today. I have some time around 2pm to 3pm, which is about 9am -10am your time. Cheers, Roberto
Hi @roobyz Great. I can meet today but from 2:30pm your time if that's ok? I have to drop my son off at school at 2pm (9am here) Let me know if that is still ok for you.
Cheers, Ben
hi @jamestagal ... works for me. Let's try... https://meet.google.com/dbd-mhaa-mep
Hi @roobyz Thanks for your time...Sorry I froze and had to join again but you must have left already...Thanks again for your time and great work! much appreciated..I think I can implement my changes in a more efficient ways now..
Cheers, Ben
hi @jamestagal , Great catching up Ben. No worries. Have fun on the theme enhancements. As discussed, I've already committed the fixes for the bugs you mentioned on our call. In addition, I've updated the search component to work on both titles and body content.
Cheers, Roberto
Hello @roobyz
I noticed that all route pages get the accented underline except for the Posts page. See screenshot below.
Do you know what could be causing this issue? Is it related to the undefined element issues ?
Please have a look when you can.
Thanks Ben