search

jamestalmage / supports-hyperlinks

Detect whether a terminal emulator supports hyperlinks
MIT License
54 stars 13 forks source link

Fix: Publish types (+ validate and use types + generate type maps) #21

Closed voxpelli closed 1 year ago

voxpelli commented 1 year ago

I noticed that this package was generating types but then told npm to only publish browser.js and index.js and not the actually generated types.

This fixes that + generates declarations maps + validates the types with TS strict=true.

It also adds a tsconfig.json to tell eg. VSCode that hey, this repository wants you to make use of TS types in index.js.

Tell me if you want me to pull something of this PR and I'll make it more granular 👍

Note: I bumped the lowest supported Node-version to a reasonable current LTS-focused version range so that the tsconfig.json file could be pointed towards a reasonable fitting definition with correct lib definition: es2020

Fixes #15

Closes #20

voxpelli commented 1 year ago

Anything I can do to help push this further?

sindresorhus commented 1 year ago

https://github.com/jamestalmage/supports-hyperlinks/releases/tag/v3.0.0

sindresorhus commented 1 year ago

Not sure why master branch is failing when this PR passed.

https://github.com/jamestalmage/supports-hyperlinks/actions/runs/4363207180