Can't change settings on Firefox

jamestomasino / stutter

RSVP for browsers

https://addons.mozilla.org/en-US/firefox/addon/stutter/

GNU General Public License v3.0

135 stars 11 forks source link

Can't change settings on Firefox #97

Closed gael-vanderlee closed 2 years ago

gael-vanderlee commented 2 years ago

Whenever I change any setting (wpm, shortcuts etc), the changes don't save and get reset to default. This happens through the settings page and through shortcuts (alt+up arrow). I've tried disabling all other extensions and it still doesn't work. I've tried on the same machine on chrome and it works there. Hereby attached is the console log of the error when I try to change wpm.

jamestomasino commented 2 years ago

What version of Firefox are you using?

gael-vanderlee commented 2 years ago

I'm on 91.9.0esr (64-bit), on MacOS Monterey on a M1 pro MBP.

jamestomasino commented 2 years ago

That's the issue after all. Object.hasOwn was released to replace Object.hasOwnProperty, but it didn't get into Firefox until version 92. Knowing there's ESR versions older than that out there I'm going to need to put in some fallbacks. Thanks for the heads up.

gael-vanderlee commented 2 years ago

Indeed, updating Firefox to 100 fixed the issue. Keeping this open until it's fixed for ESR.

jamestomasino commented 2 years ago

This has been fixed in v1.12.7