search

jamestthompson3 / nvim-remote-containers

Develop inside docker containers, just like VSCode
Other
876 stars 26 forks source link

fix iter_matches call for nvim 10 #26

Closed jbohanon closed 10 months ago

jbohanon commented 1 year ago

The function signature for iter_matches changes in neovim 10 with this PR. Omitting the argument from the function should have been safe from my understanding of the stack-based implementation of the lua interop with C, but the value at the position in the stack where this parameter was expected was 1, which throws this error since it is neither nil nor a table.

This PR is opened as draft because this may not be desired until the upstream neovim 10 is released. For one reason or another I am on the dev builds of neovim, so I needed this fix.

jamestthompson3 commented 1 year ago

Awesome! Thanks for the PR. I will merge it when nvim 10 gets published as the stable nvim build.

jamestthompson3 commented 10 months ago

@jbohanon Can you resolve the conflict and then this can can be merged in!