search

jamesturk / jellyfish

🪼 a python library for doing approximate and phonetic matching of strings.
https://jamesturk.github.io/jellyfish/
MIT License
2.04k stars 157 forks source link

jellyfish.soundex yields DeprecationWarning PY_SSIZE_T_CLEAN in python 3.8 #125

Closed motin closed 4 years ago

motin commented 4 years ago

jellyfish.soundex in python 3.8 yields DeprecationWarning: PY_SSIZE_T_CLEAN will be required for '#' formats

Just a warning so far, but will require a change in future python versions.

Tenzer commented 4 years ago

Same for jellyfish.levenshtein_distance, taken from example in README:

Python 3.8.1 (default, Jan  7 2020, 10:39:14)
[Clang 11.0.0 (clang-1100.0.33.16)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import jellyfish
>>> jellyfish.levenshtein_distance(u'jellyfish', u'smellyfish')
<stdin>:1: DeprecationWarning: PY_SSIZE_T_CLEAN will be required for '#' formats
2
Tenzer commented 4 years ago

I had a stab at fixing this in https://github.com/jamesturk/cjellyfish/pull/7.

henrist commented 4 years ago

@jamesturk This was fixed in https://github.com/jamesturk/cjellyfish but the submodule of this repo is still poining to the old version, so it is not fixed for the jellyfish package yet.

Any timeline for a new release including the changes in https://github.com/jamesturk/cjellyfish/pull/7 ?

jamesturk commented 4 years ago

Thanks for the ping on this, just pulled the update into the repo. I'll look at a new release as soon as I have a bit of time.

On Sun, Mar 22, 2020 at 6:57 PM Henrik Steen notifications@github.com wrote:

@jamesturk https://github.com/jamesturk This was fixed in https://github.com/jamesturk/cjellyfish but the submodule of this repo is still poining to the old version, so it is not fixed for the jellyfish package yet.

Any timeline for a new release including the changes in jamesturk/cjellyfish#7 https://github.com/jamesturk/cjellyfish/pull/7 ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jamesturk/jellyfish/issues/125#issuecomment-602290031, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAB6YSDLLL6HKQUG6LNX73RI2JWZANCNFSM4JPQPCCQ .