search

jamesturk / jellyfish

🪼 a python library for doing approximate and phonetic matching of strings.
https://jamesturk.github.io/jellyfish/
MIT License
2.04k stars 157 forks source link

Add aarch64 CI and wheel build support #137

Closed odidev closed 3 years ago

odidev commented 3 years ago

Closes https://github.com/jamesturk/jellyfish/issues/136

jamesturk commented 3 years ago

really appreciate this, I'll take some time soon to integrate this. a bit of a busy week ahead of me so it might be a while, but I do appreciate it 👍

layday commented 3 years ago

Can we use cibuildwheel here to build wheels for Windows and macOS as well? You can find a sample workflow at https://cibuildwheel.readthedocs.io/en/stable/faq/#emulation. I can do this in a separate PR if you'd prefer.

odidev commented 3 years ago

@layday, I pushed the changes to build Windows and macOS wheels as well via cibuildwheel. Can you please take a look? Thanks.

layday commented 3 years ago

LGTM :)

jamesturk commented 3 years ago

I’ll aim to take a look at this this week.  Thanks all!

James On Mar 8, 2021, 8:18 AM -0500, layday notifications@github.com, wrote:

LGTM :) — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

jamesturk commented 3 years ago

Sorry, I had this PR and #135 linked in my head. I'm not that familiar with the tools being used in this one, I'm curious if it is possible to add aarch support to the wheels that are now building as part of that PR's merge?

layday commented 3 years ago

135 is building 'vanilla' Linux wheels which you cannot even upload to PyPI AFAIK on account of the fact that they are not guaranteed to work on any system other than the one they've been compiled on. If you'd rather not use cibuildwheel, you can use the Docker images provided by the manylinux project directly, see https://github.com/pypa/manylinux#docker-images.

jamesturk commented 3 years ago

Gotcha, I'll need to do some reading to understand better where things like QEmu come into play

ofek commented 3 years ago

@odidev would you mind rebasing?

odidev commented 3 years ago

@jamesturk, could you please take a look at this PR? Thanks in advance.

jamesturk commented 3 years ago

thanks for this, it looks good to me

odidev commented 3 years ago

@jamesturk , I can see on PyPi, the latest release is done on Aug 05, 2021 but AArch64 wheels are missing. Could you please let me know the schedule to release AArch64 wheels?

jamesturk commented 3 years ago

If you have time/ motivation the github actions could use a second pass to get the arch working.

No ETA here yet but i’d take a look again when i have free time On Aug 11, 2021, 7:04 AM -0400, odidev @.***>, wrote:

@jamesturk , I can see on PyPi, the latest release is done on Aug 05, 2021 but AArch64 wheels are missing. Could you please let me know the schedule to release AArch64 wheels? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.