search

jamesturk / jellyfish

🪼 a python library for doing approximate and phonetic matching of strings.
https://jamesturk.github.io/jellyfish/
MIT License
2.04k stars 157 forks source link

Crashes in recent releases #146

Closed nijel closed 2 years ago

nijel commented 3 years ago

Recent releases starting with 0.8.4 cause Weblate testsuite to crash. To me, it seems there is something wrong in the binary wheel for cjellyfish, but I didn't yet find time investigate that deeper.

The crash on GitHub actions:

/home/runner/work/_temp/988f1f7c-01c9-46c4-8bc3-1ea4098717f7.sh: line 1:  8872 Killed                  coverage run ./manage.py test
Error: Process completed with exit code 137.

For example, it can be seen here: https://github.com/WeblateOrg/weblate/runs/3343181381?check_suite_focus=true

Looking at the diff https://github.com/jamesturk/jellyfish/compare/v0.8.3...v0.8.4, I don't see anything obvious what could cause such problems...

jamesturk commented 2 years ago

Without more context there isn't much we can do, if you can provide us with a failing test, etc. please re-open

nijel commented 2 years ago

Sorry, I have no clue how to trigger this outside our testsuite. For now, we're addressing this by blacklisting all recent jellyfish releases (see https://github.com/WeblateOrg/weblate/commit/b8b9e2a6fe60b80c1836acea1e45dc5bcbd8c6ee).