jamesturk / jellyfish

🪼 a python library for doing approximate and phonetic matching of strings.
https://jamesturk.github.io/jellyfish/
MIT License
2.04k stars 157 forks source link

testdata/ is missing in sdist (since 0.11.0) #180

Closed mgorny closed 1 year ago

mgorny commented 1 year ago

It seems that sdist no longer includes files necessary for the tests to pass. With 0.11.0, I'm getting:

=============================================================== ERRORS ================================================================
______________________________________________ ERROR collecting tests/test_jellyfish.py _______________________________________________
tests/test_jellyfish.py:25: in _load_data
    with open("testdata/{}.csv".format(name), **open_kwargs) as f:
E   FileNotFoundError: [Errno 2] No such file or directory: 'testdata/jaro_winkler.csv'
        name       = 'jaro_winkler'
jamesturk commented 1 year ago

Thanks for pointing this out, I'll get a fix in the next patch release

On Tue, Mar 28, 2023, at 12:00 AM, Michał Górny wrote:

It seems that sdist no longer includes files necessary for the tests to pass. With 0.11.0, I'm getting:

=============================================================== ERRORS ================================================================ ______________________________________________ ERROR collecting tests/test_jellyfish.py _______________________________________________ tests/test_jellyfish.py:25: in _load_data with open("testdata/{}.csv".format(name), **open_kwargs) as f: E FileNotFoundError: [Errno 2] No such file or directory: 'testdata/jaro_winkler.csv' name = 'jaro_winkler'

— Reply to this email directly, view it on GitHub https://github.com/jamesturk/jellyfish/issues/180, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAB6YTLITY7R4VT6XFFKVTW6JV6XANCNFSM6AAAAAAWKA3OAM. You are receiving this because you are subscribed to this thread.Message ID: @.***>

jamesturk commented 1 year ago

just kicked off a build of v0.11.1 which should fix the issue

mgorny commented 1 year ago

Thanks. However, I think you forgot to update the version number in Cargo.toml.

jamesturk commented 1 year ago

indeed, fixed now 👍 thanks for your patience w/ the new process

mgorny commented 1 year ago

Yeah, 0.11.1 works for us. Thanks!