Closed MartinoMensio closed 1 year ago
This is currently being investigated within maturin, so just ignore/discard this PR at the moment.
Martino
An update on this issue and how it has been solved:
v1.0.0-beta.7
selected for musl targets, that fixes the mismatch of EXT_SUFFIX from gnu
to musl
happening with musl and CPython3.11Cargo.toml
to pyproject.toml
. Before the beta it was already deprecated but was not causing issues (see warning message in builds). This was generating ModuleNotFoundError: No module named 'jellyfish._rustyfish'
https://github.com/PyO3/maturin/blob/main/Changelog.md#01416---2023-03-26 Now the build of the wheels works and I tested them via docker. No more import errors are generated.
Only downside: for now the CI.yaml has to specify the beta maturin version because it's not yet in stable. Probably in a month we will need to remove that line.
We still need to wait the v0.14.17 to appear in https://github.com/PyO3/maturin-action/blob/main/versions-manifest.json
Now no downsides, maturin stable v0.14.17 fixes it. This PR currently only contains a change targetting the deprecated rust module name from Cargo.toml to pyproject.toml
Hi, After doing some tests, I discovered that the wheel available for musllinux python 3.11 does not work due to an issue with pyo3/maturin. On lower python versions or on normal linux instead it works.
https://github.com/PyO3/maturin/issues/1559
This generates the following error:
To reproduce on the latest jellyfish I am following this script:
We should find a way to test the generated wheels in github actions with docker, to be sure to generate working wheels.
Best, Martino