search

jamesturk / jellyfish

🪼 a python library for doing approximate and phonetic matching of strings.
https://jamesturk.github.io/jellyfish/
MIT License
2.07k stars 159 forks source link

cp312 built distributions are missing for Windows, macOS, and musllinux #197

Closed remyjette closed 1 year ago

remyjette commented 1 year ago

Since jellyfish requires a rust toolchain to build from a source distribution, installation is challenging on Windows macOS and musllinux without a built distribution.

The cp312 built distributions are available on PyPI for manylinux, but other platforms are missing.

jamesturk commented 1 year ago

Thanks for the nudge on this. Just pushed a new CI config & will push out a release now.

Update: Hitting a strange error trying to build right now, I'll need revisit later

pwbriggs commented 1 year ago

@jamesturk Any update on this? I did some experimentation myself and I can't figure out that error either.

jamesturk commented 1 year ago

Not beyond a bit of checking which uncovered the fact it it specific to running the Python 3.12 stuff on GH actions. I put it aside hoping it'd resolve itself, but I think I need to try to reproduce in a smaller repo and/or open a support ticket.

On Fri, Nov 3, 2023, at 6:58 PM, Peter Briggs wrote:

@jamesturk https://github.com/jamesturk Any update on this? I did some experimentation myself and I can't figure out that error either.

— Reply to this email directly, view it on GitHub https://github.com/jamesturk/jellyfish/issues/197#issuecomment-1793252920, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAB6YRISBGCVQTT27E7UCTYCWAKNAVCNFSM6AAAAAA54WFRL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTGI2TEOJSGA. You are receiving this because you were mentioned.Message ID: @.***>

Chuck321123 commented 1 year ago

I had the same problem when trying to install Spyder with python 3.12 as Spyder requires jellyfish. However, a guy mentioned that by installing jellyfish version 0.7.1 (with pip) the installation worked, which it also worked for me. Use this information @jamesturk if its helpful.

jamesturk commented 1 year ago

This is now resolved, please let me know if you encounter any issues with 1.0.3

pwbriggs commented 1 year ago

Nice work, @jamesturk, thanks! It works for me!

I'm curious now, though. What was that CI error about?

jamesturk commented 12 months ago

It was a tiny issue with the venv script, https://github.com/python/cpython/issues/112252