search

jamesturk / jellyfish

🪼 a python library for doing approximate and phonetic matching of strings.
https://jamesturk.github.io/jellyfish/
MIT License
2.04k stars 157 forks source link

Bumped version of pyo3 dependency #202

Closed wtcross closed 9 months ago

wtcross commented 9 months ago

Bumped the minor version of the pyo3 dependency from 0.18.0 to 0.20.0. Also bumped patch version of this project from 1.0.2 to 1.0.3.

wtcross commented 9 months ago

I am new to rust and was hoping to use this library as part of a polars extension. I didn't realize that it's not possible to use cdylib crates in another project. Would you be open to splitting out the rust functionality into a separate crate so it can be used in rust projects?

wtcross commented 9 months ago

The polars project is massive, but you can see how they did it in their repo. If you're open to it I could take a stab at modifying the code base and submitting a pr. That way the rust ecosystem could benefit from the great functions you have implemented in this library.

jamesturk commented 9 months ago

Do you have a sense of what kinds of changes need to be made? Since it already builds as a rust crate, is it more than just changing the crate type? I'm not that familiar with rust packaging beyond this.