search

jamesward / osgi-version-maven-plugin

1 stars 2 forks source link

Progress OSGi #4

Open Sandared opened 5 years ago

Sandared commented 5 years ago

Hi @jamesward ,

I'm not sure if you are getting updates from PRs that are closed, because I didn't get any answer from you on this subject. If you prefer a PR for jQuery then I will happily do it, otherwise it would be kind of you to give me a hint on how to do a PR for the polymer library, as I couldn't find any repository for the webjar of that library.

Kind regards, Thomas

zhsc commented 5 years ago

Is this the polymer webjar?

https://github.com/webjars/polymer

zhsc commented 5 years ago

Actually that appears to be an older version.

Maybe polymer is only supported using the new bower style webjar? I'm not sure I really know the direction webjar is moving and if this old style is deprecated.

I did find this conversation though https://github.com/webjars/webjars/issues/1670

zhsc commented 5 years ago

It seems like we'd need to either upgrade the polymer classic webjar or maybe adapt the github style webjar generator code to do the same as the new plugin.

Found this but I'm not sure how maven connected it is vs template generator. https://github.com/webjars/webjars/blob/master/app/templates/pom.scala.xml

Sandared commented 5 years ago

Maybe the adaptation of the classic polymer webjar would be the easiest solution for now. I will make a PR soon. Thanks for your input @zhsc .

jamesward commented 5 years ago

A little bit of background...

Classic WebJars are deployed manually from Maven builds. But the Classic Polymer WebJar became nonviable at Polymer version 2.x due to the way Polymer was being distributed.

Bower WebJars are created not by a Maven build, but by a custom packager. The way we were doing some things wasn't compatible with Polymer 2.x so we created a new Bower GitHub WebJar type which added better support for Polymer 2.x. Unfortunately this approach seems nonviable for Polymer 3.x.

So when we talk about adding OSGi support to WebJars we stated with the manual Maven builds (for Classic WebJars). We still need to test this approach but I wouldn't recommend doing it on the defunct Polymer 1.x WebJar. After we test things on a Classic WebJar, we need to translate what the Maven build is doing into the custom Bower / NPM WebJar packager. But as noted, this will only work for Polymer 2.x WebJars.

Sorry this is a mess. We inherit the messiness of the JavaScript packaging world and then add our own messiness. Messy^2