jameswennmacher / NotificationPortlet

Apache License 2.0
0 stars 0 forks source link

Added error to studentJobs.json but do not see error on page #13

Closed jameswennmacher closed 10 years ago

jameswennmacher commented 10 years ago

In tomcat's webapps/NotificationPortlet/WEB-INF/classes/demo/studentJobs.json change

"errors": [
],

to

"errors": [
    {
        "error": "Error example - Service Not Available",
        "source": "Demo 2 Service"
    }
],

Restart Tomcat.

Do not see an error message. Verified errors is in JSON response to portlet.

doodelicious commented 10 years ago

Added error div HTML to jsp page, to display the text (should be a red background with a darker red border).

jameswennmacher commented 10 years ago

I added JSON error of:

"errors": [
    {
        "error": "Error example - Connection Timeout",
        "source": "Demo Service"
    }
 ],

and restarted Tomcat. Resulting page is cluttered.

  1. Have error text be: Demo Service: Error example - Connection Timeout Do not display the key. Do not add 'Contact your administrator for help.' It may be a transient condition that will be resolved on its own.
  2. I suggest moving error message above Search (between tabs and Search/Filter). However if there are reasons to leave it where it is because of proximity to interactions, that's fine.
  3. Perhaps remove some of the extra white space around the error and don't have the font size so big. Takes up too much vertical real estate.

image

With 2 errors it is even more crazy. Suggest it simply display as Demo Service: Error example - Connection Timeout Demo Service: Error2 example - Connection bad

image

doodelicious commented 10 years ago

Made message more succinct; smaller text