jamesy012 / OpenPlanet-BestCheckpoints

Open Planet plugin for Trackmania 2020 that tells you how quick you were compared to your best time for a checkpoint
https://openplanet.dev/plugin/bestcheckpoints
MIT License
3 stars 2 forks source link

No progress on multilaps #1

Open KevindeB93 opened 2 years ago

KevindeB93 commented 2 years ago

Hi,

Thank you for creating this plugin. It is very helpful and fun to use during grinding maps. I have been using the plugin yesterday while I was training for an endurance race on a multilap track with a planned total of 33 laps with 4 separate checkpoints. I observed that on 2 occasions that after 6-7 laps the tool doesn’t update, even when I obliterate my Best theoretical possible lap time.it didn’t update at all. It could be that it is an information overload on a multilapper, but I didn’t expect it to happen already after 6-7 laps.

jamesy012 commented 2 years ago

Hey glad your liking the plugin,

Interesting problem though, would assume it's either getting the total number of laps wrong or thinking each checkpoint is a finished lap, probably the latter. I only tested it on a max of 3 laps in a map(smaller nascar tracks) so can see how this could have slipped through, I'll take a look at some longer maps and work out what's going on later today

jamesy012 commented 2 years ago

Didn't really find anything in my testing, hard to find a map like what you mentioned, is that map on trackmania exchange?

Otherwise i'll probably put out an update for what i've changed so far on the weekend so when that happens hopefully it helps out

KevindeB93 commented 2 years ago

Hi, thank you for your swift replies and action. I was doing it on an old TMFL map in my Club Kevin's workshop on a server on Lap mode so I could increase the amount of laps. If you want a map to test, I made a map with 100 laps called Circle of death. that one is 100 laps driving in circles on dirt, lap time about 12 seconds.

I already really appreciate you looking into the issue.

KevindeB93 commented 2 years ago

Here is a link to my stream where I observed it.

The race started at 16m05. https://www.twitch.tv/videos/1291512963?t=00h16m05s

And here I started on lap 08 a significant faster lap of 48.x which was significant faster than the projected fastest time basis CPs of 53.x https://www.twitch.tv/videos/1291512963?t=00h22m46s

So in this 6 minutes it starts happening. Apologies for my incredible voice haha! better put some music on as i have muted that in my vods.

jamesy012 commented 2 years ago

Let me know how the 1.1 update goes for this problem Hopefully I did something to fix it...

Otherwise I added the delta to last lap which seems useful for these kind of 30+ lap kind of races. will have to enable it in the settings since it's not on by default

KevindeB93 commented 2 years ago

Hi.

I have tried to use your tool again.... Unfortunately it didnt work out as intended as apparently the tool thought that i only did one lap. I am pretty sure that I activated the multilap override. Please find attached the .json file

li64vsNldsDFof0ABDl70oG3uij.zip

jamesy012 commented 2 years ago

Hey mate sorry about all the trouble

json file wont be too useful, it just stores out the data from that window (also that json file was for a different plugin 😂)

if you do feel like helping out a little bit more enabling logging in the settings and see what it says,

Like I just got this in the Circle of death map you mentioned

Log Example - turned on logging [ Platform] [10:07:47] Saving settings - reset car [ ScriptRuntime] [10:07:52] [BestCheckpoints] Car no longer valid.. [ ScriptRuntime] [10:07:53] [BestCheckpoints] Running reset [ ScriptRuntime] [10:07:53] [BestCheckpoints] saving times? false [ ScriptRuntime] [10:07:53] [BestCheckpoints] Ready to read checkpoints [ ScriptRuntime] [10:08:00] [BestCheckpoints] Checkpoint change 3/2 [ ScriptRuntime] [10:08:05] [BestCheckpoints] Checkpoint change 2/1 [ ScriptRuntime] [10:08:08] [BestCheckpoints] Checkpoint change 1/0 [ ScriptRuntime] [10:08:11] [BestCheckpoints] Checkpoint change 0/3 [ ScriptRuntime] [10:08:11] [BestCheckpoints] Lap finish: 1/100 [ ScriptRuntime] [10:08:14] [BestCheckpoints] Checkpoint change 3/2 [ ScriptRuntime] [10:08:17] [BestCheckpoints] Checkpoint change 2/1 [ ScriptRuntime] [10:08:20] [BestCheckpoints] Checkpoint change 1/0 [ ScriptRuntime] [10:08:31] [BestCheckpoints] Checkpoint change 0/3 [ ScriptRuntime] [10:08:31] [BestCheckpoints] Lap finish: 2/100 - did two laps - reset [ ScriptRuntime] [10:08:35] [BestCheckpoints] Car no longer valid.. [ ScriptRuntime] [10:08:37] [BestCheckpoints] Running reset [ ScriptRuntime] [10:08:37] [BestCheckpoints] saving times? false [ ScriptRuntime] [10:08:37] [BestCheckpoints] Ready to read checkpoints - turned off multi lap - reset [ ScriptRuntime] [10:09:03] [BestCheckpoints] Car no longer valid.. [ ScriptRuntime] [10:09:05] [BestCheckpoints] Running reset [ ScriptRuntime] [10:09:05] [BestCheckpoints] saving times? false [ ScriptRuntime] [10:09:05] [BestCheckpoints] Ready to read checkpoints [ ScriptRuntime] [10:09:12] [BestCheckpoints] Checkpoint change 3/2 [ ScriptRuntime] [10:09:16] [BestCheckpoints] Checkpoint change 2/1 [ ScriptRuntime] [10:09:19] [BestCheckpoints] Checkpoint change 1/0 [ ScriptRuntime] [10:09:22] [BestCheckpoints] Checkpoint change 0/3 [ ScriptRuntime] [10:09:22] [BestCheckpoints] Lap finish: 1/100 [ ScriptRuntime] [10:09:22] [BestCheckpoints] Race Finished - did two laps, hopefully this Race Finished text aint going off for you here - reset [ ScriptRuntime] [10:09:33] [BestCheckpoints] Running reset [ ScriptRuntime] [10:09:33] [BestCheckpoints] saving times? true [ ScriptRuntime] [10:09:33] [BestCheckpoints] Validation before save [ ScriptRuntime] [10:09:33] [BestCheckpoints] Ready to read checkpoints

One possible thing could be the times don't exactly match what trackmania says, but if it's still just randomly stopping during a race that part shouldnt matter

KevindeB93 commented 2 years ago

Hi James,

So I just did another run. And I think I have found one thing your plugin may not take into account. When I have a room on Laps with infinite amount of laps for a specific amount of time, the plugin will only count the first lap. Please find below attached screenshot where the plugin mentions the race is finished but there is still over 12 minutes on the clock. if you want I can try later tonight to replicate same below where I will only adjust the room setting from infinite laps to 3 laps in combination with a time limit. I have all settings ticked on btw.

Best Check points bug 1

KevindeB93 commented 2 years ago

So I just try to do as I mentioned to have a time limit to complete an amount of laps. This is a map with 41 CPs, so may overload the plug in at the start. But When opening the map with these settings, I got the message that the plugin was unstable and has been closed. Please find below. Best Check points bug 2

jamesy012 commented 2 years ago

ahh shit didnt expect the first issue (and only so far 😂) for the plugin to be such a hassle to work out lol

Thanks for all your time helping me fix it though

in that 2nd screenshot there should be some more red text further up with the actual error thats crashing the plugin, something odd in the ui side of it tho based on that yellow text afterwards, gives me something to try out in the morning, actually giving it a quick look before i head off, i reckon it was the estimated time breaking things

1st image also odd, it says there's only one lap for the map, so im possibly grabbing that info from the wrong spot

Thanks again for the help.. might need to find some maps with 40+ checkpoints too haha

KevindeB93 commented 2 years ago

I think you need something like this?

Best Check points bug 3

The map with the 40/41 CPs is the map from the 24 hour race. As I participated in that one, I am familiar with it and know about it haha.

Just let me know if you want me to try or test things. This week I only have tonight, the rest of the week not possible to test until after the weekend.