search

jamf / JAWA

Jamf Automation and Webhook Assistant
MIT License
130 stars 12 forks source link

RHEL installer modifies the default nginx.conf #31

Closed UniversalSuperBox closed 5 months ago

UniversalSuperBox commented 2 years ago

I've noticed that the installer script for RHEL and CentOS modifies the default nginx.conf:

https://github.com/jamf/JAWA/blob/fbfdaf17b4f2d1370a92f396a2df927bcf1681e7/bin/rhel_installer.sh#L331-L334

Modifying the default config file could cause problems with multi-application deployments or existing proxy servers.

Instead, this script should act similar to Ubuntu with a small tweak. In Ubuntu, nginx modular configurations are loaded from /etc/nginx/conf.d/*.conf and /etc/nginx/sites-enabled/*.conf; the latter is loaded to provide a similar interface to Apache2 in Debian and Ubuntu. In RHEL, only /etc/nginx/conf.d/*.conf is loaded by default. This comes from the default config file's line include /etc/nginx/conf.d/*.conf;.

Therefore, JAWA should place its modular configuration inside the /etc/nginx/conf.d/ directory.

ball42 commented 2 years ago

Good point, and thanks for the insight & tip. Initial testing of the proposed changes were successful, so the RHEL installer will be updated accordingly. Thanks again

ball42 commented 5 months ago

resolved in #46