search

jamf / NetSUS

NetBoot and Software Update Server
https://jamfnation.jamfsoftware.com/viewProduct.html?id=180
304 stars 68 forks source link

Better to use parentheses for print #128

Closed pickworth closed 5 years ago

pickworth commented 5 years ago

Fixes #127

Parentheses for print() make Python3 happy.

duncan-mccracken commented 5 years ago

Hi @nmors,

This will need to reviewed with all the implementations of python2 that are in the supported operating systems, before it can be merged.

Currently support for Ubuntu 18 is only experimental, and as such, code specifically for making python3 happy may potentially break all the supported operating systems.

Duncan

pickworth commented 5 years ago

@duncan-mccracken print with parentheses is also supported on python2 fyi.

Anyway, I'm going to run with my fork and continue testing on python 3. There are a few other things that need changing. I'll make sure that I don't break support for python 2

Thanks.

Another alternative is to modify the installation script for ubuntu 18.04 to install python2 instead of python3

duncan-mccracken commented 5 years ago

Also be aware that reposado is added verbatim from the upstream repo, so customising any of the SUS functionality will potentially get messy as the reposado code would need to be modified every time its revised.

pickworth commented 5 years ago

I'll see how it goes for me for a while. If it turns out to be more trouble than what it's worth, I'll just roll back to python2