jamf / PPPC-Utility

Privacy Preferences Policy Control (PPPC) Utility
MIT License
741 stars 47 forks source link

Long code signing requirements are not fully displayed #54

Closed macblazer closed 3 years ago

macblazer commented 4 years ago

As a user of this app I would like the full code signing requirement to be displayed for the selected item so that I understand exactly what the full requirement is.

Currently when an item is selected in the left-most list, it's name, bundle identifier, and code signing requirement are displayed in the top of the window. The code signing requirement is given two lines of text to display, and if it is longer then the top half of a third line will display (sometimes). This is especially noticeable when the window is shrunk to it's minimum horizontal size. Jamf Pro's Self Service app has a long requirement; Sublime Text also has a long requirement.

We could either cap it at two lines and give some indicator that there is more with a hover displaying the full text, or we could make the requirement scrollable, or we could have it auto-expand to more lines as needed. The auto-expand would still probably require some hard upper limit (so the rest of the controls are still usable) so the hover or scrollable solution would be needed anyway for really really long requirements.

macblazer commented 4 years ago

I believe the easiest solution here is to simply

  1. Truncate the label with ellipses after two lines,
  2. Bind the tooltip field to the same thing as the value.
  3. Fix the resizing to always be two lines only instead of sometimes showing half of a third line.

Note: Those top fields seem to extend all the way to the right edge of the window. It would be extra nice if while fixing this display issue the right side of the fields was pushed in from the right edge the standard padding width.