search

jamf / Subprocess

Swift library for macOS providing interfaces for both synchronous and asynchronous process execution
MIT License
34 stars 8 forks source link

Initial release #1

Closed cyrusingraham closed 4 years ago

cyrusingraham commented 4 years ago

README

cyrusingraham commented 4 years ago

@hisaac Thanks for reviewing the code. I was thinking of holding off on the .swiftlint.yml until there was something we wanted to customize. I did disable a few rules in code (ex. nesting) but those were in unit tests and I wanted them enabled for the library source. As far as the full MIT License text in each file, it is a great question. Let's chat about that in the next subcommittee meeting. This will be the 3rd public repository from Apple Natives and we have standardized on including the full license in the header comment of all of the source files.

cyrusingraham commented 4 years ago

@macshome Thanks! I updated the factory method names and parameters to conform to the guidelines, I am embarrassed to admit it but I didn't know that existed. I will definitely be referencing that in the future! I am not sure why Github is showing some of the files with the last newline and some do not but looking at the code locally there is a newline at the end of all of the files.