search

jamf / jamfpro

JamfPro Docker image
https://www.jamf.com
MIT License
72 stars 15 forks source link

Expose DataBase.xml jdbcParameters as environment variable #25

Closed justin-watkinson-electric closed 1 year ago

justin-watkinson-electric commented 1 year ago

Is your feature request related to a problem? Please describe. When configuring JAMF Pro with Amazon Aurora, we learned that the default connection string in the DataBase.xml needed to be modified.

Describe the solution you'd like I'd like to update this section of the configuration.sh file to also include an environment variable override for the jdbcParameters XML field.

Describe alternatives you've considered Given that the ROOT.war is still compressed at bootstrap, I didn't see many non-invasive alternatives that didn't involve modifying the docker image posted to Docker hub.

battlecow commented 1 year ago

Thanks for the request, this should be completed in #26. Added both the ability to override via ENV as requested, but also as an entire DataBase.xml file mounted to /config in case the interpolation gets weird.