search

jamf / scout-public

A tool to aggregate devices across multiple MDM servers
GNU General Public License v3.0
11 stars 3 forks source link

Issues & verifications when viewing / editing reports (Not report results) #13

Closed jacobschultz closed 4 years ago

jacobschultz commented 5 years ago

Scout allows advanced reports to be created, viewed and edited for both computer and mobile devices. While they are saved as separate reports, the UI that they use is fundamentally the same. This means that bugs found in mobile device reports are likely found in computer reports as well. The database table that holds reports is called reports which holds general information about the reports, while reports_line_items stores information about each line item, in it's parent report. This table stores thing like the order in the report, criteria information, etc.

We have identified several issues when viewing and editing reports that need to be fixed. All of the report client side code lives in /app/js/scripts.js. By viewing reports we mean the report definition, not the query results of this application.

Tasks:

  1. It appears and extra line item is always added when viewing or editing an existing report. This could just be left around from generating the UI the first time. Either way, identify why this is happening and fix it. Verify the correct amount of saved line items are loaded in for both single line item and multiple line item reports.
  2. Sometimes the criteria and field to select field names aren't loaded into the report UI view properly. Figure out why this is happening and fix it. It may due to some async issues and how the html is generated. Make sure the report line items are being returned from the scout API properly, and then that the scout UI is loading them into the report view correct.
  3. The update existing report functionality appears to be broken. When editing an existing report you should be able to save it and it's updated in the database, however that's not the case. It was working in the past, so most of the functionality should be there on both the client and server, however there is an issue preventing the saving of reports right now. Investigate why and fix it.

PR Ready When:

  1. All three of the bugs are fixed, tested and verified. Viewing and editing existing reports should work in it's entirety.