Closed alex-stout closed 4 years ago
There's an issue with the extra line item still showing up but it isn't due to the original problem.
Now it's because updating an existing report by removing a line item doesn't remove it from the DB. I'm working on a fix for that case.
It should be good to go now. The fix I implemented checks if there are less line items in the new one compared to the existing one. If there's less, it deletes the current ones and makes new ones for the new ones since the order will be different and not easily determined.
I also changed how the line items are queried and returned from the API. I made it so the line items are returned in ascending order by item_order
.
Also should resolve #12
This looks pretty good after testing it - only found one thing.
When you click the blue 'view icon' in the report list table, the 'Run report' button seems like it's trying to save it, the report name also isn't loaded. (The one with the eye icon)
I also feel like we should either disable the input fields in this view, or remove that button from the table completely. I don't know how much utility there is in this view now that I look again. If you want to run the report, you can use that button, and if you actually want to view the report criteria, you can just load up the edit view.
What do you think?
I think you're right. It really doesn't have much functionality. I'll remove it.
If there is any cleanup in the UI as far as removing code for viewing, feel free to do that too!
I created this report:
And got this output (The reason why model number
doesn't have anything is because our test environment doesn't have that field populated) :
It looks like everything is working for this test case.
Resolves #13
PUT