Issues & verifications when viewing / editing reports (Not report results) Fixes

jamf / scout-public

A tool to aggregate devices across multiple MDM servers

GNU General Public License v3.0

11 stars 3 forks source link

Issues & verifications when viewing / editing reports (Not report results) Fixes #38

Closed alex-stout closed 4 years ago

alex-stout commented 4 years ago

Resolves #13

[x] Fix extra line item showing up when editing or viewing a report.
[X] Fix update report. It was two issues:
1. The field to select wasn't showing up so it wouldn't allow the PUT
2. When the put was made the server wasn't handling the parenthesis as expected. I could've changed either the frontend or the server. I decided to change the server in order to prevent any issues in the future if there's bots connected to the API.
[x] Fix criteria and field to select inputs not showing up

alex-stout commented 4 years ago

There's an issue with the extra line item still showing up but it isn't due to the original problem.

Now it's because updating an existing report by removing a line item doesn't remove it from the DB. I'm working on a fix for that case.

alex-stout commented 4 years ago

It should be good to go now. The fix I implemented checks if there are less line items in the new one compared to the existing one. If there's less, it deletes the current ones and makes new ones for the new ones since the order will be different and not easily determined.

I also changed how the line items are queried and returned from the API. I made it so the line items are returned in ascending order by item_order.

alex-stout commented 4 years ago

Also should resolve #12

jacobschultz commented 4 years ago

This looks pretty good after testing it - only found one thing.

When you click the blue 'view icon' in the report list table, the 'Run report' button seems like it's trying to save it, the report name also isn't loaded. (The one with the eye icon)

I also feel like we should either disable the input fields in this view, or remove that button from the table completely. I don't know how much utility there is in this view now that I look again. If you want to run the report, you can use that button, and if you actually want to view the report criteria, you can just load up the edit view.

What do you think?

alex-stout commented 4 years ago

I think you're right. It really doesn't have much functionality. I'll remove it.

jacobschultz commented 4 years ago

If there is any cleanup in the UI as far as removing code for viewing, feel free to do that too!

alex-stout commented 4 years ago

I created this report: Screen Shot 2019-12-05 at 9 14 32 PM-crunch

And got this output (The reason why model number doesn't have anything is because our test environment doesn't have that field populated) : Screen Shot 2019-12-05 at 8 58 09 PM-crunch

It looks like everything is working for this test case.