jamie-mh / AuthenticatorPro

📱 Two-Factor Authentication (2FA) client for Android + Wear OS
https://authenticatorpro.jmh.me
GNU General Public License v3.0
2.98k stars 198 forks source link

Add icons for self-hosted identity providers #1006

Closed FibreTTP closed 10 months ago

FibreTTP commented 11 months ago

Adds icons for:

They are all very popular in the self-hosted space. All optimised with Pingo.

Kvasenok commented 11 months ago

Hi @FibreTTP A few suggestions, if you don't mind. The Authelia icon has some unnecessary margins. Here is an icon remade from SVG without margins. The file size is bigger though. The source is here. authelia

Also, if you decide it needs a dark mode variant due to dark gradient, here is one. authelia_dark

FibreTTP commented 11 months ago

Thanks for that, @Kvasenok. I've optimised the logo you sent and replaced the one with the margins.

If users had an explicit choice between logo variations, I would include the white logo - but given that there are other icons in the repo that are currently as dark as the gradient Authelia logo, and that it's still fairly readable, and that I think it's easier to identify with the colour vs the shape, I'm not going to add it in. Obviously I'm happy to include it if it's blocking this merge.

Kvasenok commented 11 months ago

@FibreTTP No, it was just a suggestion. I don't think a white icon can affect the merge. The services popularity might.

jamie-mh commented 10 months ago

Thanks!