search

jamie-mh / AuthenticatorPro

📱 Two-Factor Authentication (2FA) client for Android + Wear OS
https://authenticatorpro.jmh.me
GNU General Public License v3.0
2.98k stars 198 forks source link

Reverse the visual display of assigned categories #1028

Closed bclaymiles closed 10 months ago

bclaymiles commented 10 months ago

Is your feature request related to a problem? Please describe. In the "Assign categories" dialogue, the selected categories do not have a black outline on them. The unselected categories have a black outline on them.

Describe the solution you'd like The current scheme is backwards, in my opinion. Typically, when something is selected, it gains a visual identifier, rather than losing it. I have to remind myself any time I'm selecting categories that the scheme is counter-intuitive.

Alternatively to reversing the outlining scheme, which might then confuse everyone once again by then following the intuitive scheme, perhaps just a 'filled' (colored-in) button for selected, and unselected are not filled, along with the lettering being 'greyed-out'.

jamie-mh commented 10 months ago

Hi @anastrophe ,

The current design follows the Material You guidelines for filter chips. I'd rather not change the design, as this would make it inconsistent with other apps.

Cheers

bclaymiles commented 10 months ago

I understand, but I - not a coder - visited the link you provided. The great big graphic right on the main page shows a simple 'fix' that solves the ambiguity: addition of a checkmark (a 'leading icon' as the 'spec' page for a filter describes it) to indicate the chip has been selected/activated/whatever the proper coding term is.

I don't know how hard it would be to add that, but it would be a massive improvement, from the perspective of just an average user.