search

jamie-mh / AuthenticatorPro

📱 Two-Factor Authentication (2FA) client for Android + Wear OS
https://authenticatorpro.jmh.me
GNU General Public License v3.0
2.92k stars 195 forks source link

Password request dialog sometimes doesn't disappear when authenticated with Biometrics #365

Closed cjohnsto-nz closed 2 years ago

cjohnsto-nz commented 2 years ago

S21 Ultra Exynos Android 12

I think that there are occasionally duplicates of that dialog overlaid, and that using the fingerprint scanner only closes the most recently created one.

dschoerk commented 2 years ago

I rarely notice that issue too on my Oneplus 8t, Android 12

jamie-mh commented 2 years ago

This appears to be caused by switching between the app and other apps. Can anyone confirm? Thanks.

cjohnsto-nz commented 2 years ago

Yeah. I think it shows that dialog on activity start. The dialog should set a flag on initializing that prevents another dialog from being created.

From: jmh @.> Sent: Saturday, May 21, 2022 8:52:06 PM To: jamie-mh/AuthenticatorPro @.> Cc: Chris Johnstone @.>; Author @.> Subject: Re: [jamie-mh/AuthenticatorPro] Password request dialog sometimes doesn't disappear when authenticated with Biometrics (Issue #365)

This appears to be caused by switching between the app and other apps. Can anyone confirm? Thanks. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ZjQcmQRYFpfptBannerStart CAUTION: This Email is from an EXTERNAL source. Ensure you trust this sender before clicking on any links or attachments.

ZjQcmQRYFpfptBannerEnd

This appears to be caused by switching between the app and other apps. Can anyone confirm? Thanks.

— Reply to this email directly, view it on GitHubhttps://github.com/jamie-mh/AuthenticatorPro/issues/365#issuecomment-1133582308, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFCPQMWESOT2CMKQY4YZ4SDVLCP3NANCNFSM5ND5CSJA. You are receiving this because you authored the thread.Message ID: @.***>

Chris Johnstone Production Print Specialist Ricoh New Zealand Limited Mobile: +64 21 849 115 www.ricoh.co.nz

ISO 14001 Environmentally certified | ISO 27001 Information Security Certified

jamie-mh commented 2 years ago

Fixed in eb0eb46.