jamie-mh / AuthenticatorPro

📱 Two-Factor Authentication (2FA) client for Android + Wear OS
https://authenticatorpro.jmh.me
GNU General Public License v3.0
2.98k stars 198 forks source link

Make App Display Name Translatable #960

Closed Kvasenok closed 9 months ago

Kvasenok commented 1 year ago

Since the app's name is displayed simply as "Authenticator" and not "Authenticator Pro" it seems the point is to make it look on par wih the stock or google apps (like stock gallary or wallet) as most of these terms are translateble and not some untranslatable brand names. Basically I see it this way: "Authenticator Pro" is the app's name shown in GP and anywhere else. "Authenticator" on the home screen under the app's icon is app's descriptory function, i.e. "an app with authenticators", and so I believe it should be translatable like "Gallery", "Files", "Camera" etc. If the word itself is impossible to translate into some specific language it can always be translated as "Authenticator" on CrowdIn, as it is now.

I can probably do it myself and submit a PR if I understand the code correctly, but I still need an approval.

jamie-mh commented 10 months ago

I see what you mean. However, Google Authenticator for instance shows the word "Authenticator" in both English and French. I prefer not to translate it in the French version because I think it looks a bit awkward, and I think of it as a shorthand version of "Authenticator Pro".

In what language do you think it should be translated?

Cheers

Kvasenok commented 9 months ago

@jamie-mh actually, I just checked and noticed that google removed the translation with (probably) the last design update. Same with Microsoft Authenticator, it's just "Authenticator" in the app drawer. Initially I was thinking about languages that don't use Latin lettering, like Cyrillic or Arabic languages. But I guess it doesn't make sense anymore considering Google's and Microsoft's examples.

jamie-mh commented 9 months ago

Okay, it probably makes sense to keep the text "Authenticator" for now.