Closed Kvasenok closed 10 months ago
Hi Kvasenok. I'm trying to create a pull request. But it gives me this error
Hi @OmarNazzal150 I really don't know, seems to be some kinda bug, maybe try again later. What icons did you want to add?
Here are the list
6: https://www.thrivecart.com/
10: https://www.turbosquid.com/
@OmarNazzal150 oh my... Have you checked them all against Similarweb's ranking and the app itself? For example, spri.ng is already included
I can't. It is because when i open Similar web, it forces me to create an account. To view a web It needs an account. So . I will not put my real email or use a temporary mail instead. Or check it by yourself.
Here's a screen recording https://github.com/jamie-mh/AuthenticatorPro/assets/135146653/f5e6abc0-9582-4e89-9539-902e903bd695
@OmarNazzal150 I'm sorry, but I don't know what you're talking about. Similarweb doesn't require to log in to search a website and check it for it's ranking
Now, what should I do?. I'm sorry I can't check the ranking global. Just check it by yourself
@OmarNazzal150 please create a separate icon request as usual
First icon. https://cloudconvert.com/
@OmarNazzal150 I mean please create an issue with icon request according to instructions
Okay 👌🏻
At 1001#
Oh. Nevermind
Note: spri.ng just needs a dark theme icon/white icon
https://www.similarweb.com/website/spri.ng/#overview
https://www.similarweb.com/website/turbosquid.com/#overview
https://www.similarweb.com/website/ti.to/#overview
https://www.similarweb.com/website/timetastic.co.uk/#overview
https://www.similarweb.com/website/thrivecart.com/#overview
https://www.similarweb.com/website/teslafi.com/competitors/
https://www.similarweb.com/website/studioninja.co/#overview
https://www.similarweb.com/website/test.de/#overview
https://www.similarweb.com/website/weclapp.com/#overview
https://www.similarweb.com/website/vivup.co.uk/competitors/
https://www.similarweb.com/website/unleashedsoftware.com/#overview
https://www.similarweb.com/website/workato.com/#overview
https://www.similarweb.com/website/whimsical.com/#overview
https://www.similarweb.com/website/wellfound.com/#overview
https://www.similarweb.com/website/surveymonkey.com/#overview
https://www.similarweb.com/website/yclas.com/#overview
https://www.similarweb.com/website/xplenty.com/#overview
One more icon to add. But it is a Russian website. Here 👇🏻
https://www.similarweb.com/website/gosuslugi.ru/#overview
Gosuslugi
(https://github.com/jamie-mh/AuthenticatorPro/assets/135146653/b58e503d-0966-4310-8fa1-59641299ca9b)
@OmarNazzal150
Ok
I think I'm done. @jamie-mh, all I can do is add the icons I mentioned in my P.S., otherwise ready to merge.
I don't know why it suddenly started to give me a check error. And yes, I keep finding something to update, but this PR can be merged any time, I'll just create a new one.
@jamie-mh I'm totally done. See the first comment for notes and questions. I didn't mean to dump so much information, but I'd appreciate your feedback.
Hi @Kvasenok ,
Thanks, very nice work once again. There's not much to add, but here are just a couple comments:
As for your suggestions, I think you're correct about the Bitrix24, Wise, Award Wallet, Hide Me and Steam icons. They lack contrast in the dark mode currently, and your improvements are good.
Thanks
@jamie-mh Thanks for the comments! I've updated the icons accordingly. Reverted changes for Borgbase and Uber, added dark mode icons for Bitrix24, Wise, Award Wallet, Hide Me, NameSilo and Steam and updated icons for Nintendo, Obsidian.md and IONOS. I've also deleted the 1&1 icon.
I've tried to find a better dark mode icon for CodeShip and couldn't understand something. Does it need its own icon at all? I have no idea what kind of service this is and all I could find out with quick googling is that it's part of CloudBees and probably(?) uses the same account. Shouldn't we have the CloudBees icon instead of CodeShip?
It looks like a standalone product with its own accounts, so it makes sense to have a CodeShip icon in this case.
It looks like a standalone product with its own accounts, so it makes sense to have a CodeShip icon in this case.
Ok. I still want to find a better dark mode icon for it because the current one makes the two icons look like they have different size, since one has a white circle. Maybe something like this?
Yes, that looks good. It's much better if the light and dark versions are the same size.
Yes, that looks good. It's much better if the light and dark versions are the same size.
Done. If you have any thoughts about alternative icons for Call of Duty and Control D, I can still update them. Otherwise I don't have anything to add and this PR is ready for merge.
It all looks good to me. Thanks again!
This PR mostly focuses on updating icon colors and dark mode icons, but also includes some new icons and rebrandings.
Updated
I also updated icons for Ajax Systems, Activision, JumpCloud and HTX but I didn't count them because it was just a quality update.
Added
Extra icons
P.S.
Dark Mode suggestions
I have a few icons that don't really need a dark mode version but could benefit from the functionality. For example, below are a few possible dark mode variants next to the default light mode icons. Since Codeberg has a dark mode variant I thought it was worth a try.
Bitrix24
This is a dark mode icon for Bitrix24 using the second main color, see this logo
Wise
This is a light mode icon for Wise, because the current icon was supposed to be a dark mode icon but I compromised. Again, not needed, but would look better.
Award Wallet
This is a dark mode icon for Award Wallet. The grey icon is visible enough on dark backgrounds, but they use a white icon for dark backgrounds as it still keeps a small light-grey part to remain recognizable.
Hide.me
This is a dark mode icon for Hide.me. Since the silhouette is in the blue triangle it works on dark mode already, but the silhouette itself blends in with the background right now.
Steam
I've read the discussion about Steam interchangeably using three icon, so I thought 'maybe a compromise?' How about using the default gradient icon for light mode and the white icon for dark mode? Examples below
I didn't add these icons because this is against the guidelines and a bit excessive, but it can be good from a design standpoint, so can be added if necessary.
Suggestions
Nintendo
I've seen the whole discussion about the Nintendo icon and I would like to offer 2 options.
Option 1. Red N A simple solution, but I've seen it being used in different icon packs
Option 2. Framed Red N A so-called "micrologo" taken from wiki. Also a simple icon that still keeps Nintendo's identity
IONOS
I really don't like the use of the text logo here, but if I change the icon to a favicon with transparent background it looks like a line (see below). I still can do it though. Like I said, I really don't like the use of the text logo.
Obsidian.md
It's been just recently added in #932 by @ch3thanhs and is based on the branding guidelines, but it's an app icon and a flatter icon is used on the main page, as a favicon and as a part of the logo. So I propose to use this flatter icon instead of the app icon.
NameSilo
It definitely needs a dark mode icon, I just couldn't find any guidelines so I don't know which option to choose. a) If the the background/frame is important, we just reverse colors and leave it at that.
b) If the background/frame is not important, we just remove it completely and leave the icon.
c) Or maybe even use a secondary color for the dark mode. After researching their website and blog it seems to be the most correct option.
EVE Online
They have a favicon and I'm trying to remove text logos, but I don't know if this is too much. Looks good on the tile display option though.