jamiebrynes7 / obsidian-todoist-plugin

Materialize Todoist tasks in Obsidian notes
https://jamiebrynes7.github.io/obsidian-todoist-plugin/
MIT License
912 stars 69 forks source link

Checking a task inside a callout triggers an obsidian-tasks warning #239

Open mathisgauthey opened 1 year ago

mathisgauthey commented 1 year ago

Describe the bug Checking a task inside a callout triggers an obsidian-tasks warning. It's annoying and I think the two plugins could work something out to prevent this behavior.

To Reproduce Steps to reproduce the behavior: Install obsidian-todoist-plugin and obsidian-tasks plugins from community plugins. You just need to add the todoist query of the todoist-plugin inside callout and check of a task. It triggers the tasks plugin warning.

Just like that :

> [!SUMMARY]+ Inbox
> ```todoist
> name: Inbox
> filter: "#Inbox"
> ```

Expected behavior When I check a tasks inside the Todoist-Plugin, which is inside a call out on my daily note, it shouldn't interfere with the task plugin by displaying the callout warning. Or at least I should be able to deactivate this warning myself.

Screenshots When I check a task inside the querry that is inside one of the callouts of my daily note, this happens :

Screenshot_20230612-082118

My setup is as follows :

Screenshot_20230612-082927

Screenshot_20230612-083038

Desktop (please complete the following information):

Additional context Links to the two others issues in obsidian-tasks plugin :

claremacrae commented 1 year ago

@jamiebrynes7 Hi, just to add save you a bit of time, what I was suggestion in one of those Tasks reports in this comment:

The Todoist aspect of this issue itself is not something that I personally would investigate alone, for two reasons:

If you can talk to the author of the Todoist plugin and find out if there is any way that other plugins can identify whether a task is in a Todoist code block, that would be helpful.

Once we know that, there's a conversation to be had about whether Tasks should just ignore and tasks that are in a Todoist code block, as in not do any checks for recurring tasks, and not add a Done Date.

jamiebrynes7 commented 7 months ago

Hi @claremacrae, sorry for the (very) late reply on this! It possible to identify a task via CSS classes on the surrounding element. Anything that is a child of either todoist-task-list or todoist-task-container will be a Todoist plugin task.

I don't know how the Tasks plugin identifies task items, but if those don't work, I can add something directly onto the input checkbox directly, let me know!

claremacrae commented 7 months ago

Hi @jamiebrynes7, thanks for the reply.

What I tell users in the docs about bugs involving another plugin is:

We do not generally work on problems of Tasks interacting with other plugins unless the author of that plugin is willing to work jointly on the problem.

Spending time getting familiar another plugin's settings, behaviour and code would take time away from improving Tasks.

So, if you would be willing to have an online call for me to show you the relevant sections of code in Tasks and see if we can identify a way forward, please send an email to at the address in my profile here.

I'm very busy for the next several weeks, and am usually booked up with several pairing sessions each week - so the sooner we can get a session in the diary, the better.

Hope to hear from you.

claremacrae commented 7 months ago

I can also show you the reason behind the warning - it's possible you have figured out an alternative solution to that problem - in which this whole issue just goes away.

(The reason I avoid having conversations about this sort of thing via GitHub is that it is just too low bandwidth to be effective, and is prone to time-wasting misunderstandings.)