search

jamiebrynes7 / spatialos-sdk-rs

Rust integration of the SpatialOS C API bindings
Apache License 2.0
21 stars 6 forks source link

`FloatOrd` newtype #165

Closed jamiebrynes7 closed 4 years ago

jamiebrynes7 commented 4 years ago

Possible implementation for https://github.com/jamiebrynes7/spatialos-sdk-rs/pull/153#issuecomment-602252163 wherein we try to use a wrapper newtype to make f32/f64 implement Ord.

This code was adapted from https://github.com/notriddle/rust-float-ord with a set of trait implementations added to aid usability: Deref, DerefMut, +-/*, and the assign variants thereof.

randomPoison commented 4 years ago

As unfortunate as it is to not be able to use f32/f64 directly, this is probably the most reasonable solution for now. I'm in favor of getting this merged in πŸ‘

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f11baf7). Click here to learn what that means. The diff coverage is 42.63%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #165   +/-   ##
=========================================
  Coverage          ?   19.96%           
=========================================
  Files             ?       41           
  Lines             ?     4217           
  Branches          ?        0           
=========================================
  Hits              ?      842           
  Misses            ?     3375           
  Partials          ?        0
Impacted Files Coverage Ξ”
cargo-spatial/src/download.rs 0.00% <0.00%> (ΓΈ)
project-example/src/generated.rs 0.00% <0.00%> (ΓΈ)
project-example/src/main.rs 0.00% <0.00%> (ΓΈ)
spatialos-sdk/src/worker/schema.rs 3.59% <ΓΈ> (ΓΈ)
spatialos-sdk/src/worker/schema/primitives.rs 33.07% <0.00%> (ΓΈ)
spatialos-sdk/src/worker/schema/float_ord.rs 45.09% <45.09%> (ΓΈ)
spatialos-sdk/src/worker/entity_builder.rs 62.02% <100.00%> (ΓΈ)
spatialos-sdk/src/worker/schema/bundle.rs 87.07% <100.00%> (ΓΈ)
cargo-spatial/src/config.rs 0.00% <0.00%> (ΓΈ)
cargo-spatial/src/lib.rs 0.00% <0.00%> (ΓΈ)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update f11baf7...5ffe4a7. Read the comment docs.