search

jamiecaesar / securecrt-tools

SecureCRT scripts, written in Python, for doing various tasks when connected to Cisco equipment.
Apache License 2.0
246 stars 78 forks source link

SaveRunning Does not work on ASA #28

Closed mzarglis closed 7 years ago

mzarglis commented 7 years ago

AttributeError

Error: 'NoneType' object has no attribute 'group' line: 69 session = StartSession(crt)

jamiecaesar commented 7 years ago

I haven't tested against ASAs much. There are a couple issues with these scripts working against the ASAs. I think I have them fixed, but I'm going to put the code in the "re-write" branch so I can do some more testing with it. Feel free to run that version of the scripts and if things seem stable, I'll merge it into the master branch.

EDIT - These changes weren't added to the "dev" branch, but the "re-write" branch, which is the one where I've put my ground-up re-write to all of the scripts. This is the branch I plan on using and updating going forward, and eventually will overwrite the master branch once I'm comfortable the new works just as well (or better) than the older ones.

mzarglis commented 7 years ago

Tested the rewrite branch on:

asa 8.29(x) & 9.1(x) code lines successfully

Thanks a lot for these scripts!!

One more thing in comments on script_settings.json you what I assume is your companies gitlab for info on the debug-mode and modify term settings. If you could add those to the github readme.

Thanks again scripts are great

jamiecaesar commented 7 years ago

Thanks for reporting back on how the updates have worked. I haven't been doing much firewall work lately, so that is a weak area for the scripts (plus the CLI is different enough to cause problems).

Also, thanks for pointing out that comment from the json file -- I do need to add that that info to both places (I don't think I ever got around to enabling debug mode, so that is a pointless setting for now... Ultimately I'd like it to create logs for each run when enabled for easier troubleshooting but finding the time is always an issue)

I'll close the issue since this sounds resolved.