search

jamiecaesar / securecrt-tools

SecureCRT scripts, written in Python, for doing various tasks when connected to Cisco equipment.
Apache License 2.0
246 stars 78 forks source link

Added support for Cisco AireOS Wireless LAN Controllers #49

Closed AirManic closed 4 years ago

AirManic commented 4 years ago

Offering up my work to add support for Cisco AireOS WIreless LAN Controllers (WLC).

jamiecaesar commented 4 years ago

This looks awesome and I appreciate you for putting this together and contributing it to this repository. I plan to dig into this more later tonight. I realized I had a few things in the devel branch that were never merged into master, so I did that and it caused a merge conflict on one file (sessions.py). I think I can deploy this PR into a new branch and sort that out, or if it looks easy on your side to change the destination to the devel branch, that would be helpful as well.

In short, I just want to make sure I can deploy this somewhere that I can make sure all of the Sphinx auto-generating documentation stuff is in place before merging into master.

Thanks again!

AirManic commented 4 years ago

Not a programmer at heart, so I am learning. Had to sort of hack in how to detect it is a Cisco AireOS WLC. BTW, actually my first experience with github, so hope I did it correctly. Once you accept, I will pull your master back into my master and compare to my branch(es). Have more coming on this front, but what I submitted was a solid chunk to get started. .:|:.:|:. Gordon Rogier, CCIE-Wireless #26419 | Technical Leader, Customer eXperience | 972.358.1580 | grogier@cisco.commailto:grogier@cisco.com

From: Jamie Caesar notifications@github.com Sent: Monday, May 4, 2020 2:18 PM To: jamiecaesar/securecrt-tools securecrt-tools@noreply.github.com Cc: Gordon Rogier (grogier) grogier@cisco.com; Author author@noreply.github.com Subject: Re: [jamiecaesar/securecrt-tools] Added support for Cisco AireOS Wireless LAN Controllers (#49)

This looks awesome and I appreciate you for putting this together and contributing it to this repository. I plan to dig into this more later tonight. I realized I had a few things in the devel branch that were never merged into master, so I did that and it caused a merge conflict on one file (sessions.py). I think I can deploy this PR into a new branch and sort that out, or if it looks easy on your side to change the destination to the devel branch, that would be helpful as well.

In short, I just want to make sure I can deploy this somewhere that I can make sure all of the Sphinx auto-generating documentation stuff is in place before merging into master.

Thanks again!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jamiecaesar/securecrt-tools/pull/49#issuecomment-623654005, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APBEUSASIVLQN4IIDOKQNKDRP4IIFANCNFSM4MYOYFQQ.

jamiecaesar commented 4 years ago

I've merged these changes into a new branch called AirManic-dev-AireOS.

On your local machine (assuming you are using a cli version of git) you can navigate to the directory where you've cloned my securecrt-tools repository (not a forked version), and type git checkout -b AirManic-dev-AireOS origin/AirManic-dev-AireOS to pull down everything that has been merged into that branch.

I'll probably make some changes to that branch to make sure the documentation is generated correctly, so do git pull every now and then to make sure you have the latest. As an example, I already made a tweak so the scripts would work on my ISR-AP1100AC-B. Any other PRs you submit, make sure they go to this new branch (not master) so they'll merge in with the existing code. Once things seem solid and I've had some time to test things out, I can merge all of these into the master branch.

Anyone else who wants to use these in the meantime will just need to switch to this branch to have these scripts available.

jamiecaesar commented 4 years ago

Also, please let me know if you have any problems accessing the new branch.

jamiecaesar commented 4 years ago

Made some fixes to the AireOS branch, based on testing against my home WLC, and merged it into the master branch. @AirManic -- please let me know if you find any issues with your scripts after pulling master.

AirManic commented 4 years ago

Will check out a bit later and let you know. Sounds great. .:|:.:|:. Gordon Rogier

From: Jamie Caesar notifications@github.com Sent: Tuesday, May 26, 2020 3:06 PM To: jamiecaesar/securecrt-tools securecrt-tools@noreply.github.com Cc: Gordon Rogier (grogier) grogier@cisco.com; Mention mention@noreply.github.com Subject: Re: [jamiecaesar/securecrt-tools] Added support for Cisco AireOS Wireless LAN Controllers (#49)

Made some fixes to the AireOS branch, based on testing against my home WLC, and merged it into the master branch. @AirManichttps://github.com/AirManic -- please let me know if you find any issues with your scripts after pulling master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/jamiecaesar/securecrt-tools/pull/49#issuecomment-634250229, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APBEUSBNXIO5FWPQ4UNMJMTRTQOJBANCNFSM4MYOYFQQ.