jamieeeleow / pe

0 stars 0 forks source link

Invalid Name Input #2

Open jamieeeleow opened 1 year ago

jamieeeleow commented 1 year ago

Usually names would just be alphabets and spaces, however for the name attributes, numbers are considered valid which may lead to invalid names as shown below. Upon the command add n/123 p/123, the application accepted numbers as a valid input for the name.

image.png

Maybe a consideration could be to include the restriction of not having numbers available in a name.

nus-se-script commented 1 year ago

Team's Response

Thank you for your feedback. To clarify, we have to consider the possibility that the user may not use the person's legal name when adding them to EduMate. For instance, they could have a friend named 50 cent or Brfxxccxxmnpcccclllmmnprxvclmnckssqlbb11116, and that should be a valid name and entry in EduMate. As such, it does not value-add to EduMate if we add this additional validation check. Instead, it would be an inconvenience to the user if they do want to use numbers in their friends' names.

Finally, we believe that this does not warrant a Medium severity because the user is highly unlikely to type such a name (as you have claimed, such a name should not exist) and propose a change to Low instead. Additionally, this should be classified as a Feature Flaw instead of a Functionality Bug given that this is intended behaviour.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]