jamieeeleow / pe

0 stars 0 forks source link

Increasing validity check for email #6

Open jamieeeleow opened 1 year ago

jamieeeleow commented 1 year ago

image.png

As seen from the attached image, it isn't compulsory for the email to have a ".com" or ".sg" or ".edu" etc and this may lead to an invalid email address being added into EduMate and hence perhaps it could help to include checks for at least a ".something".

nus-se-script commented 1 year ago

Team's Response

Please refer to:

StackOverflow

As seen in the link above, emails without the "dot" are still valid, though they might be rare. It does not value-add if we were to tighten the restriction as well. We could set up email verification, but it would have been out of scope.

Since you claim that the email is not valid, it would be a rare case that the user will encounter such an issue. Hence, severity is low because it does not hinder usage of the user.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: While it may not hinder the user when using the application, the application will not achieve its fullest potential if a user were to copy the wrong email and try contacting the wrong person.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]