Challenge 3 Feedback

[aespaldi]

Challenge 3 Feedback Overall: 10/24 .

• Passing but your should work on refactoring code and getting a working recursive dfs.

Feedback based on Challenge 3 Rubric:

• Read & output 2/4

  • read method is ok
  • output is hardcoded

• Graph class 2/4

  • Not clear why you have a Graph and LinkedList class - can these be combined? Rename LinkedList to accurately reflect it's use.

• DFS 1/4

  • You have the start of the recursive method but it does not run properly and needs to be reformatted. This method can be written in <10 lines with proper use of the graph class.

• Code organization 1/4

  • Your methods are a bit long and convoluted. Try thinking of single responsibility - what is the one thing this method can do. Often if a method is over 40 lines, that's a good indicator that it may need to be broken up. When you do define helper methods, be careful defining them as nested functions when they really shouldn't be. EX: findVertexIndex should be a method of the vertex class not a nested function in find_path. Come see me or TA for help in refactoring.
  • Testing 2/4
  • add exception handling to graph reader and other volatile code. Add more tests.

• Documentation 2/4

  • run pycodestyle to discover and correct formatting and code convention issues. Also, update camelCase to snake_case for function names for PEP8 standards.(this was a typo in original tutorial - but was fixed)