jamiekurtz / JwtAuthForWebAPI

Nuget-deployed library for securing your ASP.NET Web API service with JSON Web Tokens (JWT).
GNU Lesser General Public License v3.0
68 stars 28 forks source link

Any plans to make this work in vNext? #10

Open georgiosd opened 9 years ago

jamiekurtz commented 9 years ago

Definitely! Though admittedly haven't given it much thought yet.

Is it not working in vNext?

jamiekurtz commented 9 years ago

... also... OWIN support is something on the radar

georgiosd commented 9 years ago

Uhm, I am under the impression the API has changed completely because of the new middleware? I could be wrong.

robianmcd commented 8 years ago

Just tried using this in ASP.NET Core 1.0 and I get the error message "The dependency JWT 1.3.4 in project Mercury does not support framework DNXCore, Version=v5.0."

jamiekurtz commented 8 years ago

Interesting... I will try to take a look this coming weekend. I'm guessing that the Microsoft JWT library itself doesn't work in new Core.

BTW - On what OS and version are you finding this error?

Jamie Kurtz Solutions Architect and Consultant

http://www.jamiekurtz.com http://www.jamiekurtz.com?utm_source=email&utm_medium=signature&utm_campaign=general | https://twitter.com/jakurtz http://www.linkedin.com/in/jamieakurtz | http://github.com/jamiekurtz

On Wed, Feb 10, 2016 at 9:30 AM, Rob notifications@github.com wrote:

Just tried using this in ASP.NET Core 1.0 and I get the error message "The dependency JWT 1.3.4 in project Mercury does not support framework DNXCore, Version=v5.0."

— Reply to this email directly or view it on GitHub https://github.com/jamiekurtz/JwtAuthForWebAPI/issues/10#issuecomment-182398055 .

robianmcd commented 8 years ago

I got the error on Windows 10

BrandonClapp commented 8 years ago

@jamiekurtz, I think @georgiosd is correct. For the vNext stuff you will need to create an OWIN middleware in order to support what is currently being done in WebApiConfig.Register() since this is the new way of tying in to the new HTTP request pipeline.

Additionally, Web API and MVC are now one and the same.

It may be worthwhile to create a separate repo for the vNext stuff since it will be drastically different.

jamiekurtz commented 8 years ago

Thanks @robianmcd and @BrandonClapp . At this point I don't have any plans to update this library to work with vNext/Core/OWIN. Happy to review or discuss further.

johnvcoleman-w24 commented 7 years ago

@BrandonClapp I'm at the same crossroad now (would like to have this work with Core), did you guys fork this or cook up your own solution?

robianmcd commented 7 years ago

I ended up using this solution http://stackoverflow.com/questions/30546542/token-based-authentication-in-asp-net-core-refreshed/33217340#33217340

johnvcoleman-w24 commented 7 years ago

Sweet. Thanks for the pointer @robianmcd and thanks @jamiekurtz, this package really made life simpler!

BrandonClapp commented 7 years ago

@johnvcoleman-w24 This was for a side project and I don't think I ever followed through with implementing JWT in it.

That being said, I think there is a JWT authentication middleware in asp.net core found in the Microsoft.AspNetCore.Autnentication.JwtBearer nuget package.

A fairly descriptive explanation for the implementation can be found here: http://stackoverflow.com/a/39822153/1730061

Edit: it looks like this was the route @robianmcd took, too.

johnvcoleman-w24 commented 7 years ago

@BrandonClapp thank you sir! 👍 I have some reading to do...