search

jamielennox / requests-mock

Mocked responses for the requests library
https://requests-mock.readthedocs.io
Apache License 2.0
450 stars 71 forks source link

Honor cookies in the session #220

Open jaraco opened 1 year ago

jaraco commented 1 year ago

Builds on and supersedes #143. Fixes #17.

This PR addresses all of the concerns identified in #143.

It currently merges with #219 as I was unable to test without it. I'll be factoring that out now.

jaraco commented 9 months ago

Any thoughts on this change? It's still an issue for me downstream.

jaraco commented 9 months ago

I see this PR becomes conflicted with e3bd0d1a92e40fa9cb1d587c59157020a45de620. It's not immediately obvious to me how to reconcile those changes. It's been a long time since I looked into this issue.

jaraco commented 9 months ago

Even though this bug is fixed in my branch, the fact that it's not released means that I'm running into problems releasing jaraco.net. I had previously tried putting the workaround in the tox config only, but that caused problems because the "deps" weren't being honored in the "diffcov" job (https://github.com/jaraco/jaraco.net/actions/runs/7946382294/job/21694053671).

@jamielennox What sort of assistance can you provide and is there any commitment you can make to get this fix rolled out? If not, I might need to think about other options like forking this project.