jamielennox / requests-mock

Mocked responses for the requests library
https://requests-mock.readthedocs.io
Apache License 2.0
450 stars 71 forks source link

Fix type hint of `Mocker.__enter__/__exit__` #257

Closed Viicos closed 7 months ago

jamielennox commented 7 months ago

Thank you, checked this compared to the search on the internet. A bit weird that you can't do this in a more supported way, but sure.

Viicos commented 7 months ago

Thank you, checked this compared to the search on the internet. A bit weird that you can't do this in a more supported way, but sure.

I agree it's a bit verbose. As a side note:

jamielennox commented 7 months ago

Oh, I didn't even register the external import as it all seemed to work. I only recently dropped py2 support, now I should merge all these type definitions back into the regular code base and it will make gaps like this a lot more obvious.

Thanks