jamielennox / requests-mock

Mocked responses for the requests library
https://requests-mock.readthedocs.io
Apache License 2.0
450 stars 71 forks source link

python-purl outdated #266

Open pgajdos opened 2 weeks ago

pgajdos commented 2 weeks ago

Hello,

python-purl looks not under development. Could you eventually consider to use another library or drop this single test?

pgajdos commented 2 weeks ago

Or, make it optional:

Index: requests-mock-1.12.1/tests/test_adapter.py
===================================================================
--- requests-mock-1.12.1.orig/tests/test_adapter.py
+++ requests-mock-1.12.1/tests/test_adapter.py
@@ -14,9 +14,14 @@ import http.client
 import io
 import json
 import re
+import unittest
 import urllib.parse

-import purl
+with_purl = True
+try:
+  import purl
+except:
+  with_purl = False
 import requests
 from urllib3 import HTTPResponse

@@ -345,6 +350,7 @@ class SessionAdapterTests(base.TestCase)
             resp = self.session.get(u)
             self.assertEqual('resp', resp.text)

+    @unittest.skipUnless(with_purl, "purl not available")
     def test_with_purl(self):
         self.adapter.register_uri('GET',
                                   purl.URL('mock://www.tester.com/a'),