search

jamiepollock / Umbraco-MigrationsViewer

An Umbraco plugin that allows backoffice users to see what Migrations are installed on an Umbraco instance.
Apache License 2.0
1 stars 2 forks source link

Data is not bound in list view #1

Closed dawoe closed 8 years ago

dawoe commented 8 years ago

The data binding is not happening correctly. I see a row for all my records, but no data in them

migrations viewer

This is easily fixed by changing the view

 <tbody>
<tr ng-repeat="item in items">
     <td>{{item.Version}}</td>
     <td>{{item.CreateDate}}</td>
</tr>
</tbody>

The Api returns the properties starting with a uppercase letter

jamiepollock commented 8 years ago

Haha, bizarre! I've had it return lowercase locally. I think I'm going to have to add the JsonCamelCaseFormatter filter attribute on to ensure it's consistent. I'll get a fix in added after lunch :)

jamiepollock commented 8 years ago

I'm fairly new to this, what would be the best way to test this? Could I provide the nuspec from the appveyor build and you could test locally? I don't have a myget feed at this point.

jamiepollock commented 8 years ago

@dawoe maybe because I'm mad with power or perhaps I don't know any better I've released a new version which should fix the issues you're having here.

Could you update to the latest nuget package and see if it fixes this?

jamiepollock commented 8 years ago

@dawoe Looks like I was super hasty about using JsonCamelCaseFormatter. Turns out it's causing issues with other Controllers returning JSON.

I've removed it now, but if people are using JsonCamelCaseFormatter in their own code it will cause an issue.

jamiepollock commented 8 years ago

Closing this issue for now as this was an issue using JsonCamelCaseFormatter in the target website. Now I've removed it from this package's code and implemented @dawoe's original suggestion.