Closed Villane closed 8 years ago
Thanks for all your work, some great additions.
On Sunday, 29 May 2016, Erkki Lindpere notifications@github.com wrote:
Besides the catch-up, I added detection of HD vs SD content. Since this plug-in only plays HD videos in SD, I think it's important to show which videos could be played in HD instead using a different client. I tried to add 'overlay: 6' to metadata, which should cover it AFAIK, but it doesn't work, maybe due to a limitation in xbmcswift2? So in addition to the overlay, I added " [HD]" to list view title of the movie, and added another attribute to meta-data for the clean title.
Known bugs with this version that I was too lazy to fix:
- Multiple directors are shown without space between them: Andrew Gray,Adam Gray (this is mubi.com bug also, but could be fixed)
- Special mark-up in synopsis is not handled and will show up as garbage
You can view, comment on, or merge this pull request online at:
https://github.com/jamieu/plugin.video.mubi/pull/8 Commit Summary
- Catch up with current mubi.com site
File Changes
- M resources/lib/mubi.py https://github.com/jamieu/plugin.video.mubi/pull/8/files#diff-0 (80)
Patch Links:
- https://github.com/jamieu/plugin.video.mubi/pull/8.patch
- https://github.com/jamieu/plugin.video.mubi/pull/8.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jamieu/plugin.video.mubi/pull/8, or mute the thread https://github.com/notifications/unsubscribe/AAFk5cmUK2lcFVBtqEFOGVuCt8W0uVHfks5qGYVogaJpZM4IpR2_ .
Besides the catch-up, I added detection of HD vs SD content. Since this plug-in only plays HD videos in SD, I think it's important to show which videos could be played in HD instead using a different client. I tried to add 'overlay: 6' to metadata, which should cover it AFAIK, but it doesn't work, maybe due to a limitation in xbmcswift2? So in addition to the overlay, I added " [HD]" to list view title of the movie, and added another attribute to meta-data for the clean title.
Known bugs with this version that I was too lazy to fix: